Skip to content

Conversation

lgmsantos
Copy link
Contributor

@jbrockmendel
Copy link
Member

Needs a test

@pep8speaks
Copy link

pep8speaks commented Aug 8, 2019

Hello @lgmsantos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-22 11:33:56 UTC

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a release note to doc/source/whatsnew/v0.25.1.rst?

@TomAugspurger TomAugspurger added this to the 0.25.1 milestone Aug 8, 2019
@gfyoung gfyoung added Bug Indexing Related to indexing on series/frames, not to indexes themselves Series Series data structure labels Aug 9, 2019
@lgmsantos
Copy link
Contributor Author

How can I fix those failed checks? They seem unrelated to the changes.

@TomAugspurger
Copy link
Contributor

Try merging master and re-pushing?

@TomAugspurger
Copy link
Contributor

Merged master. Ping on green.

@TomAugspurger TomAugspurger merged commit b1c871c into pandas-dev:master Aug 22, 2019
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 22, 2019
TomAugspurger pushed a commit that referenced this pull request Aug 22, 2019
galuhsahid pushed a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
pandas-dev#27814)

* BUG: Series.rename raises error on values accepted by Series constructor.
galuhsahid added a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
* master: (40 commits)
  DOC: Fix GL01 and GL02 errors in the docstrings (pandas-dev#27988)
  Remove Encoding of values in char** For Labels (pandas-dev#27618)
  TYPING: more type hints for io.formats.printing (pandas-dev#27765)
  TST: fix compression tests when run without virtualenv/condaenv (pandas-dev#28051)
  DOC: Start 0.25.2 (pandas-dev#28111)
  DOC: Fix docstrings lack of punctuation (pandas-dev#28031)
  DOC: Remove alias for numpy.random.randn from the docs (pandas-dev#28082)
  DOC: update GroupBy.head()/tail() documentation (pandas-dev#27844)
  BUG: timedelta merge asof with tolerance (pandas-dev#27650)
  BUG: Series.rename raises error on values accepted by Series construc… (pandas-dev#27814)
  Preserve index when setting new column on empty dataframe. (pandas-dev#26471)
  BUG: Fixed groupby quantile for listlike q (pandas-dev#27827)
  BUG: iter with readonly values, closes pandas-dev#28055 (pandas-dev#28074)
  TST: non-strict xfail for period test (pandas-dev#28072)
  DOC: Update whatsnew (pandas-dev#28073)
  CI: disable codecov (pandas-dev#28065)
  CI: Set SHA for codecov upload (pandas-dev#28067)
  BUG: Correct the previous bug fixing on xlim for plotting (pandas-dev#28059)
  CI: Add pip dependence explicitly (pandas-dev#28008)
  DOC: Change document code prun in a row (pandas-dev#28029)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Indexing Related to indexing on series/frames, not to indexes themselves Series Series data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Series.rename raises error on values accepted by Series constructor.

5 participants